Matthieu Riegler comments

Results 808 comments of


                                            Matthieu Riegler

Aria-package documentation: Hide menu-icons from accessible text in example page

We should probably add `aria-hidden` to all those icons.

Fix inconsistent typeof ngDevMode usage in Router package (undefined vs 'undefined')

Looks like the issue is much larger, #63875 introduced that issue accross multiple packages.

feat(devtools): show @for loops in components tab

Yeah that would make sense.

feat(devtools): show @for loops in components tab

Hey @Avcharov great that you're looking into it. Do you mind opening a draft PR so we can have an early look into it. This will help us to guide...

fix(core): handle view destruction during effect execution

If this is the same issue as #62822, this is probably not the fix we want.

fix(core): handle view destruction during effect execution

Chatted offline with Arturo. TLDR: We probably want to allow an effect to destroy its component but we should still run the effect cleanup function.

fix(core): handle view destruction during effect execution

(can you please resolve the conflict ?)

fix(core): handle view destruction during effect execution

[TGP](https://fusion2.corp.google.com/presubmit/841702397/OCL:841702397:BASE:841757947:1765208231605:99f3833e;groups=PossiblyNewlyFailing,PossiblyAlreadyFailing/targets) looks "green" to me

Proposal: Add Template-Scoped Singleton Option for Pipes

Each usage of the pipe is its own instance and the memoization is per-instance. So each pipe transforms at least once.

Proposal: Add Template-Scoped Singleton Option for Pipes

No, there is isn't and as Pawel said, they are glorified functions with memoisation. You could replace them is a function an take carte of the memoisation yourself.