Matthieu Riegler

Results 603 comments of Matthieu Riegler

This is by design, the underlying APIs don't support adding multiple class in a single string (`classList.add` throws). Also Angular doesn't want to have to add the cost of handling...

For what it's worth, explicit dependencies has an issue, you cannot build an implicit effect on top of an explicit effect function. But the opposite is true. You can build...

To help you a bit, You will need to update our API goldens with `yarn bazel run //packages/compiler-cli:error_code_api.accept` and `yarn bazel run //packages/compiler-cli:extended_template_diagnostic_name_api.accept`

We try to make our test explicit when there is an action required by developers. The actual command is given along side the failure I you're looking for them !

You should be able to run the same tests on your own machine with `test:ci` :)

@dollebrolle The merge had to be reverted because it was breaking inside google. The feature wasn't shipped yet.

Hi, could you please rebase the changes. As #60495 will take `8115`, can you use `8116` for that diagnostic. Thank you.

Running the diagnostic against google's codebase surfaced some interesting issues. I could narrow it down as following : ``` @Component({ template: '' }) class UnrelatedComponent {} // unexported @Directive({ selector:...

Do you still have the issue if you restart the language service manually ? (You can do this via the VScode Command Palette).