Matthieu Riegler comments

Results 335 comments of


                                            Matthieu Riegler

@angular-devkit/build-angular:server with optimization: true fails in 16.1.4. 16.1.1 works well

It's this line that is throwing : https://github.com/angular/domino/blob/aa8de3486307f57a518b4b0d9e5e16d9fbd998d1/lib/HTMLParser.js#L2645C59-L2645C60

Providing a DI token in commonEngine.render() does not provide its value to application

Hi, have a look at #26175 which updated the schematics to import create the tokens that aren't exported anymore. You will need to provide the tokens yourself.

Providing a DI token in commonEngine.render() does not provide its value to application

@hudzenko You can still update to v17 and keep using the `browser` (webpack) or `browser-eslint` builder.

Providing a DI token in commonEngine.render() does not provide its value to application

@Tom4U You can update to v17 and use either the `browser` or the `browser-esbuild` builders. Both work like before.

Add .clear() to remove all member controls of FormGroup|FormRecord

While it makes sense for an `FormArray`, it doesn't for `FormGroup`. The keys are specified at creation. Maybe just for `FormRecord` then ?

setTimeout in my project now has an incorrect type

This has been fixed by ReactiveX/rxjs@c1a07b7 and shipped in 7.6 !

docs(core): Improve injectors documentation

Hi, we're looking at deprecating angular.io in favor of https://angular.dev. As your PR has curently some conflict i'm going to close it. Feel free to drop any PR for improvements...

docs: remove DI_token link

Hi, do you mind squashing your commits and reword the remaining one to follow our [commit message guidelines](https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit) ?

docs: remove DI_token link

In absence of cleanup, I'll close this PR. Feel free to reopen one if necessary !

refactor(devtools): improving type safety

Just pushed the rebase