Matthieu Riegler comments

Results 335 comments of


                                            Matthieu Riegler

docs: RouterTestingModule should be added to Testing guide

This is not the case anymore. Also we're looking at deprecating angular.io in favor of https://angular.dev/. Feel free to drop any suggestions for the new doc site, thank you.

ExpressionChangedAfterItHasBeenCheckedError is thrown by ngModel.control.disable() been called

This should be fixed by #55720 if it lands.

[Planned] adjust transpilation target above es5

Looks like right now, v8 will ship `ES2022` ESM code right ?

Type narrowing for `NgSwitch` and `NgSwitchCase`

The new control flow is pretty much implemented an available in the current RC. It will be available as a developer preview in v17 (release in early november).

FormGroup.disable() and FormGroup.enable() do not allow resetting disabled state.

AFAIK this has been "fixed" in v15. with the following breaking change https://angular.io/guide/update-to-version-15#setdisabledstate-is-always-called-when-a-controlvalueaccessor-is-attached

ExpressionChangedAfterItHasBeenCheckedError is thrown by ngModel.invalid above the ngModel control declaration

This issue will be investigated as part as the signal integration in forms. https://github.com/orgs/angular/projects/31/views/2?pane=issue&itemId=62437975

Ngclass value not updating if form input field has errors. It seems to be one tick behind.

This is a `ExpressionChangedAfterItHasBeenCheckedError` issue that would be fixed by a signal integration.

Type checking of templates that set private inputs

Agree, the error is now much more explicit.

QueryList#changes is not typed strongly

In v17.2 Angular added support for signal view queries which don't have this typing issue. This is now recommended alternative for type-satety.

Calling formGroup.updateValueAndValidity() does not update child controls that have `onUpdate` set to `'submit'`

It looks like some of you are misinterpretting this issue with #6170. This reported issue is not about updating the tree validity. Also, `updateOn: submit` indicates that the FormControl isn't...