Matthieu Riegler

Results 335 comments of Matthieu Riegler

You first need to update your fork and then rebase on main. (per the ci/circleci: setup failure).

Yeah there is a limitation still existing on V15. ` [T] extends [PermissiveControlConfig] ? FormControl : ` could be improve to ` [T] extends [PermissiveControlConfig] ? FormControl in `form_builder.ts` `

Yeah, at one time `resolveForwardRef` within `resolveProvider()` in `di.setup.ts` returns undefined. Please provide a Stackblitz.

The unit tests on `angular/components` are failing. What's the process in this case ?

@JoostK Thanks for your feedback. FYI, [here is the commit](https://github.com/angular/components/compare/main...JeanMeche:components:fix-breaking-changes-querylist) to fix components repo. Is there any doc about integrating a particular commit to the tests ?

I see that #43604 which is closely related, was pushed back to v16. I will look into it, to provide a similar schematic for the migration.

From what a gathered from the components repo, https://github.com/angular/components/blob/1186c8036182bdbb850738a57118d5bc623e9aca/src/cdk/listbox/listbox.ts#L400-L407 Is it mostly casted to `Array` ? The migration will indeed be tricky. As Joost suggested, `Observable` is a possibility but...

Let me know what you think of the migration I just push !

Closing to spare us the effort of landing a migration as we now have the signal queries.