Matthieu Riegler

Results 335 comments of Matthieu Riegler

The CLA is failing now because Bob left the angular team and likely revoked it. You'll need to remove him as an author of the commits. Also a rebase is...

I will remove the now unused `isHostElement` argument if the tests are successful.

I wanted to add a test to `animation_integration_spec.ts` I didn't find a way to run it. Any idea ? 😊

Thanks for the heads-up Jessica, you pointed me into the right direction, I needed to run the test case in karma with ``yarn test packages/core/test:test_web` The integration test I added...

Thank you Pawel, you're right. I was still a beginner when I wrote that fix 😊 We'll do the deprecation in another PR.

He's talking about the Angular DevTools extension which displays this error when it can't find an app. Why wouldn't you inspect the content of the iFrame directly ?

I'll close this as we landed #53934

Hi, this is basically a duplicate of #8203. Let's continue the discussion over there.

About the `attr.disabled` "bug", this a [breaking change/feature](https://angular.io/guide/update-to-version-15#setdisabledstate-is-always-called-when-a-controlvalueaccessor-is-attached), the "fix" is to opt-out from the new behaviour by importing the `ReactiveFormsModule` with a config. ``` ReactiveFormsModule.withConfig({ callSetDisabledState: 'whenDisabledForLegacyCode', }), ```

> The only PR touching the `formControlName` directive in v15 was #43499 by @crisbeto. This could be the cause -- I'll have to write a test to check. @dylhunn, I...