Matthieu Riegler comments

Results 602 comments of


                                            Matthieu Riegler

docs: Improve documentation about Injection context / inject

@mgechev Can I get a feedback on this one when you have some time to dedicate to it ? Thx 😊

feat(platform-browser): Expose EventManagerPlugin in the public api

Can I get the https://github.com/angular/angular/labels/aio%3A%20preview ? 😊

feat(platform-browser): Expose EventManagerPlugin in the public api

@atscott I've reduced the scope of the PR to adding `EventManagerPlugin` to the public API. Do you have any clue why `getFactoryOf` has been added to the goldens ?

feat(platform-browser): Expose EventManagerPlugin in the public api

@atscott I wanted to clean up a bit the API before making it public, as its always harder to update once it's public. * `_doc` in `EventManaerPlugin` is unused so...

docs: delete aborted documentation files

@jelbourn you probably have some inputs, since you closed all @josmar-crwdstffng PRs in december.

DevTools builds but throws error when loaded in Chrome

Thanks for the investigation !

docs(forms): warn the user about getting old values and show how to a…

Yes ! Parts of the doc (those under `/api/` in the url) are generated from the source files !

docs(forms): warn the user about getting old values and show how to a…

Hi, you still need to squash your commits !

refactor(core): remove webworker related checks on `assertDomNode`

> I would rather keep it since we are unwrapping DOM nodes from view-related data structures. Safe to remove webworker related checks though. Makes sense, PR updated.

Deprecate `@Host()`, `@Inject()`, `@Optional()`, `@Self()` & `@SkipSelf()`

@Eraldo Arent't you looking for `inject(IonRouterOutlet, { optional: true })` ?