Matthieu Riegler

Results 335 comments of Matthieu Riegler

This one is quite trivial, In your `main.ts` you probably have `platformBrowserDynamic().bootstrapModule(AppModule)`. `AppModule` is the boostrapped module and this module is missing the `boostrap` entry : ``` @NgModule({ imports: [...

Any info on what is failing on the internal tests ?

@dylhunn Thanks for the feedback, I plugged the google3 entry point and added a basic test. Tell me if you need something more 👍

I'm going through my old PRs, It believe this will shift to at least v17 ?

@dylhunn Correct me if i'm wrong, but `[5, {updateOn: 'blur'}]` works as long as it's typed correctly : `{updateOn: 'blur'} as const` instead of `blur` being just a `string` !...

@dylhunn Sounds reasonable to me ! I updated the PR !

@AndrewKushnir I took your suggestions into account !

@atscott @AndrewKushnir I think we're good this time 👍

In #48696 @pkozlowski-opensource raised a concern that some minifiers could mangle class field names thus breaking the tracking when passing only a string. Wouldn't that also apply to your directive...

I was thinking about adding some typings to the definitions (instead on `unknown` currently) to improve type assertions in the test. ![Screenshot 2023-03-13 at 00 21 19](https://user-images.githubusercontent.com/1300985/224580199-ceb4315b-3a87-4a9b-b5a6-2b632460e358.png) What do you...