lidRviewer
lidRviewer copied to clipboard
Jean-Romain
Update to SDL2
Overview
This updates the relevant C++ code in lidRviewer to use the updated Simple DirectMedia Layer 2.0 (SDL2) library. The old version, SDL1.2, is no longer supported on many OS's, so this should allow more people to use this package if they like.
This works on my machine with the following specs:
R
- R: 4.1.1
- RStudio: 1.4.1717
C++ Compiler
- clang v12.0.0 (clang-1200.0.32.29)
- standard: gnu++14
Machine
- MacOS Catalina v10.15.7
- Macbook Pro, Mid 2015 (Intel Processor, 64-bit)
Notes
- To upgrade to
SDL2, I followed the official SDL2 migration guide, as well as a super helpful thread between @Jean-Romain and @silviculturalist. If you're still gettingSDL-related errors, you may want to check out those threads for more context. - I'm happy to answer questions or help others where I can. I know @Jean-Romain has stated that this project is dormant, and I'm hoping not to create a bunch more work for him on something he'd rather not maintain 😅
If I recall correctly, I needed
PKG_CXXFLAGS = -I/usr/local/Cellar/sdl2/2.0.16/include/ -I/opt/X11/include
to point the gcc to the new SDL2 header files, as well as to the X11 headers for rendering.
I honestly don't fully recall why I needed:
PKG_LIBS= -framework OpenGL -framework GLUT -lSDL2
but I can dig back in after work (I'm on Pacific Standard Time). At the very least, I needed to link the new SDL2 library, but I don't recall off the top of my head why I needed to link OpenGL and GLUT as well.
I can confirm that this is much better for Windows systems as well, because rtools* will already have installed the SDL2 library, so you only need to link to them.
We can do that by modifying Makevars.win to:
PKG_LIBS = $(shell pkg-config --libs sdl2 glut glu)
PKG_CPPFLAGS = $(shell pkg-config --cflags sdl2 glut glu)
I would actually use Makevars.ucrt instead of Makevars.win, since I don't know for sure it will work with versions before UCRT was introduced.
I would rather rely on pkg-config for linking on unix systems as well as it will deal with packages not installed in the default paths and different sets of dependencies regarding different systems having GLUT embedded or not.
In MSYS2 windows it is a little broken though, so you actually need to manually add glut glu, but I think that won't be an issue under unix systems. Otherwise you can try using sdl2-config. If you really want that to be robust and test multiple configurations and linking I could pull request a configure.ac + configure scripts for testing appropriate configurations.
Sure if you can PR something that works on all platforms I'll be happy. The development of the package is abandoned mainly because I don't know how to make it working on all platforms. If you are able to PR something workable at least on Unix/Windows then I could start new projects on this package.
I never merged this PR because of the hard code path PKG_CXXFLAGS = -I/usr/local/Cellar/sdl2/2.0.16/include/ -I/opt/X11/include
I never merged this PR because of the hard code path
PKG_CXXFLAGS = -I/usr/local/Cellar/sdl2/2.0.16/include/ -I/opt/X11/include
Yeah, sorry for the hardcoded path there. I haven't thought about this PR in a long time, so feel free to close it. Sounds like @caiohamamura has a better path forward for multi-platform support anyway.
Otherwise I should rewrite the package without SDL using GLU which is natively available for R. This is why I abandoned the development.
Ok I checked in Rtools 43 and indeed there are some SDL2 folders. The game is changing. @caiohamamura some help may be require. If have 0 expertise on Windows but we could have this package working again.