RoboticsInfrastructure icon indicating copy to clipboard operation
RoboticsInfrastructure copied to clipboard

[Humble] Duplicate worlds in the repository

Open pawanw17 opened this issue 1 year ago • 9 comments

There exist duplicate worlds inside Worlds directory and CustomRobots/

  • roomba_robot/worlds
  • ackermann_cars/worlds
  • car_junction/worlds
  • amazon_robot/worlds
  • amazon_hospital/worlds
  • autoparking/worlds

pawanw17 avatar Oct 11 '23 10:10 pawanw17

Hi @pawanw17 , I would like to work on the issue, can i go ahead with it?

Tanishq30052002 avatar Mar 05 '24 16:03 Tanishq30052002

Sure please

pawanw17 avatar Mar 12 '24 18:03 pawanw17

hey @pawanw17 , In the repo there are different worlds files and different launch files too, so am I supposed to convert them to launch.py format too so it will be compatible with ROS2 also. Also, many more pkgs have the same problem, so could you please clarify it?

Tanishq30052002 avatar Mar 13 '24 13:03 Tanishq30052002

Hi @Tanishq30052002, In this repo mainly we have two branches which are actively developed, noetic-devel and humble-devel, inside these you can find .world files which gazebo uses, This issue is only targetting the world files and not the launch files.

pawanw17 avatar Mar 16 '24 12:03 pawanw17

Hi @pawanw17 Should I add different world files too in world directory?

Tanishq30052002 avatar Mar 16 '24 13:03 Tanishq30052002

What do you mean?

pawanw17 avatar Mar 16 '24 13:03 pawanw17

@pawanw17 Since in custom robots there are some more world files which are not duplicate to the ones in the world directory. So I want to know if we are supposed to move those world files to the world directory also?

Tanishq30052002 avatar Mar 16 '24 13:03 Tanishq30052002

@jmplaza where should we keep all the world files? inside CustomRobots folder?

That way when CustomRobots is built they would automatically be sourced, but I don't know if other applications(Visualcircuit, btstudio) build CustomRobots.

pawanw17 avatar Mar 19 '24 08:03 pawanw17

hi @pawanw17 @jmplaza I would be glad if you could please clear the task.

Tanishq30052002 avatar Mar 28 '24 09:03 Tanishq30052002