RoboticsAcademy icon indicating copy to clipboard operation
RoboticsAcademy copied to clipboard

[Frontend] Hover effect on exercise card on Homepage

Open Apoorvgarg-creator opened this issue 2 years ago • 8 comments

When hover on the exercise card, it shows blank card.

Screen recording -

https://user-images.githubusercontent.com/57873504/163565828-b7d81a51-2377-4142-a3f1-8f8d00455ce1.mov

Expected outcome -

A video must be played as per my understanding of the code below - Screenshot 2022-04-20 at 12 31 29 PM

Apoorvgarg-creator avatar Apr 20 '22 07:04 Apoorvgarg-creator

@Apoorvgarg-creator That is the expected behaviour. I have rechecked the code as well.

akshaynarisetti avatar Apr 24 '22 14:04 akshaynarisetti

@Apoorvgarg-creator That is the expected behaviour. I have rechecked the code as well.

Thank you @akshaynarisetti. So, for what purpose this Video tag is placed here ?

Apoorvgarg-creator avatar Apr 24 '22 15:04 Apoorvgarg-creator

Hi @Apoorvgarg-creator

The pre-existing code had this concept of on-hover video playing feature, guess it was taking a lot of bandwidth.

From the code I can see that they clearly dropped this idea and replaced the video src with a # placeholder. So they didn’t want the video to play for some reason most probably above.

akshaynarisetti avatar Apr 24 '22 16:04 akshaynarisetti

Hi @Apoorvgarg-creator

The pre-existing code had this concept of on-hover video playing feature, guess it was taking a lot of bandwidth.

From the code I can see that they clearly dropped this idea and replaced the video src with a # placeholder. So they didn’t want the video to play for some reason most probably above.

Thank you for the help

Apoorvgarg-creator avatar May 03 '22 05:05 Apoorvgarg-creator

@pariaspe Can I help in resolving this issue ? If yes, what should be the approach to solve the issue ? Thank you

Apoorvgarg-creator avatar May 11 '22 14:05 Apoorvgarg-creator

Hey can you assign this issue to me?

AAYUSH-droid avatar Aug 09 '22 11:08 AAYUSH-droid

Yes @AAYUSH-droid, go ahead with it :+1:

pariaspe avatar Aug 09 '22 11:08 pariaspe

Hey @AAYUSH-droid, we are slowly adopting to react based templates. You may make changes there.

@dmariaa is working on it currently 😇

https://github.com/JdeRobot/RoboticsAcademy/discussions/1783

akshaynarisetti avatar Aug 09 '22 13:08 akshaynarisetti

Would love to tackle this issue

r-Dev03 avatar Aug 28 '22 23:08 r-Dev03

Hi @r-Dev03, thanks for your interest, we already implemented this on #1779

pariaspe avatar Aug 29 '22 07:08 pariaspe