aiohomekit icon indicating copy to clipboard operation
aiohomekit copied to clipboard

Shutdown pairings when remove_pairing is called

Open bdraco opened this issue 1 year ago • 3 comments

fixes #131

bdraco avatar Sep 14 '22 07:09 bdraco

We should change Home Assistant to call .shutdown as well on unload so it doesn't try to reconnect after we unload the entry

bdraco avatar Sep 14 '22 08:09 bdraco

Codecov Report

Base: 69.39% // Head: 69.21% // Decreases project coverage by -0.18% :warning:

Coverage data is based on head (ffc93c1) compared to base (2fa0133). Patch coverage: 59.25% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
- Coverage   69.39%   69.21%   -0.19%     
==========================================
  Files          71       71              
  Lines        6084     6106      +22     
==========================================
+ Hits         4222     4226       +4     
- Misses       1862     1880      +18     
Flag Coverage Δ
unittests 69.21% <59.25%> (-0.19%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohomekit/controller/coap/pairing.py 32.00% <14.28%> (-1.34%) :arrow_down:
aiohomekit/controller/ble/pairing.py 25.43% <20.00%> (-0.23%) :arrow_down:
aiohomekit/controller/abstract.py 82.26% <90.00%> (+0.40%) :arrow_up:
aiohomekit/controller/coap/connection.py 29.97% <100.00%> (ø)
aiohomekit/controller/ip/pairing.py 79.66% <100.00%> (-0.17%) :arrow_down:
aiohomekit/utils.py 86.53% <0.00%> (-5.77%) :arrow_down:
aiohomekit/exceptions.py 79.76% <0.00%> (-3.58%) :arrow_down:
aiohomekit/protocol/__init__.py 61.95% <0.00%> (-1.96%) :arrow_down:
aiohomekit/protocol/tlv.py 98.75% <0.00%> (-1.25%) :arrow_down:
aiohomekit/controller/ip/connection.py 82.48% <0.00%> (-0.64%) :arrow_down:
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 14 '22 08:09 codecov[bot]

This all works great with bluetooth

Still need to test it with ip pairing and traveling so thats a bit harder to do. May need to wait until Saturday or if I can set up the right tunnels

bdraco avatar Sep 14 '22 14:09 bdraco

Back home. Works great with IP as well. I'm also now able to successfully unpair and repair BLE devices without a restart 👍

Will merge and release and adjust the HA side.

bdraco avatar Sep 17 '22 09:09 bdraco