Christopher Gambrell

Results 40 comments of Christopher Gambrell

> Looks good to me, and the failures seem to be unrelated. It won't hurt to rebase it and rerun the checks though. Thanks for the response, didn't want the...

> Hi there, > I'm new around here (and to open source in general), I'd be happy to work on this issue if I had a few pointers first (e.g.,...

> I was about to say you don't have to `use` types to well... just _use_ them. > > Buf if you're a noob then I'll try to explain: `use`...

> @youknowone if I'm right and there's no way to mark a `PyStructSequence` field/s to not get unpacked I don't think you can solve this issue like the author is...

> @JazzGlobal well... this is going to require major changes (completely restructuring the definition of `PyStructTime`) and unless you're up for that - and if you are then great, but...

Community is a bit more moderated since I last contributed lol. I'll look at some of the other Traverse implementations for hints on how I should do it for PyStructTime....

> I am not getting how PyTraverse is related to this problem yet. I'd like to fix pystructseq side first. > > @JazzGlobal Are you also interested in proc macro?...

@youknowone Should this be closed until that work in completed?

> How about adding `#[pystruct(skip)]` to mark fields to ignore? Do you mean `#[pytraverse(skip)]` ? EDIT: Or would `#[pystruct(skip)]` be something new

> Yes, adding a new attribute `#[pystruct()]` > > pytraverse is only used for GC, so not here. I'm not familiar with Rust macros. Will pystruct("skip") essentially be the same...