codexctl icon indicating copy to clipboard operation
codexctl copied to clipboard

Also build on macos-13 as it's intel

Open Eeems opened this issue 1 year ago • 1 comments

Eeems avatar Sep 26 '24 19:09 Eeems

Currently blocked by https://github.com/Eeems/remarkable-update-image/issues/8

Eeems avatar Sep 26 '24 19:09 Eeems

Walkthrough

Added macos-15-intel to CI job matrices and brew-install condition, standardized string quoting, renamed an artifact output, added a "Free up space" step, adjusted job needs, and bumped two dependency versions in requirements.txt to 1.3.1 (platform markers preserved).

Changes

Cohort / File(s) Summary
Workflow & CI configuration
\.github/workflows/main.yml
Added macos-15-intel to job matrices (remote/test paths); expanded brew-install if to include macos-15-intel; added "Free up space" step under remote/test_device; renamed artifact output to remarkable-compilation-report; standardized many string literals to double quotes and applied minor whitespace/formatting tweaks; updated release job needs to include test_device.
Dependencies
requirements.txt
Bumped remarkable-update-image and remarkable-update-fuse from 1.3 to 1.3.1, preserving existing platform markers (sys_platform != 'linux' and sys_platform == 'linux').

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Inspect YAML syntax/indentation around the matrix additions and modified if conditions.
  • Verify the new "Free up space" step placement and the release job needs change.
  • Confirm PEP 508 formatting for platform markers and version pins in requirements.txt.

Possibly related PRs

  • Jayy001/codexctl#148 — Similar dependency version updates for remarkable-update-image and remarkable-update-fuse.
  • Jayy001/codexctl#155 — Related dependency pin changes across requirements/pyproject files (previous bump to 1.3).

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add intel macOS build' directly describes the main change in the changeset: adding macos-15-intel to the workflow matrix and related configurations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
  • [ ] Commit unit tests in branch Eeems-patch-1

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6e63248dbdb738bf4c2fb01ebe4cc1b0666b2e2d and 846bd60d544aab2d1fdc5f4229e160a5092a730c.

📒 Files selected for processing (1)
  • .github/workflows/main.yml (7 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/main.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Build for macos-latest
  • GitHub Check: Build for macos-15-intel
  • GitHub Check: Build for ubuntu-latest
  • GitHub Check: Build for remarkable
  • GitHub Check: Build for windows-latest

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Dec 12 '25 05:12 coderabbitai[bot]

I think this is ready, both x86_64 and arm64 mach-o binaries are being generated. Based on the automated testing we do as part of the build, I'm fairly comfortable with saying this is probably working and can be merged. Any concerns @Jayy001 ?

Eeems avatar Dec 12 '25 08:12 Eeems