shinxbot2
shinxbot2 copied to clipboard
Several improving suggestions
Thanks for your wonderful work! Shinxbot helps me a lot to ease my life and improve my study ability.
However, when reviewing the source code, I found some potential coding improvements for this project:
-
homodata.txt
is actually a data file. Placing it with configuration files inconfig
does not look good to me. - Changing part of
shinx_message
and resend the message to where it comes is somewhat weird though. Imagine that you receive a message in your mobile phone and you just edit some portion and forward to others. - Since you have implemented a log system yourself, why not use it though out the repo. I noticed that std::cout, std::error was used sometimes.
-
get_log
actually meanslog_init
,setlog
is actually writing log. Moreover,get_log
andsetlog
have distinct syntax.
1&2&3 are done.