shinxbot2 icon indicating copy to clipboard operation
shinxbot2 copied to clipboard

Several improving suggestions

Open NeumoNeumo opened this issue 1 year ago • 1 comments

Thanks for your wonderful work! Shinxbot helps me a lot to ease my life and improve my study ability.

However, when reviewing the source code, I found some potential coding improvements for this project:

  1. homodata.txt is actually a data file. Placing it with configuration files in config does not look good to me.
  2. Changing part of shinx_message and resend the message to where it comes is somewhat weird though. Imagine that you receive a message in your mobile phone and you just edit some portion and forward to others.
  3. Since you have implemented a log system yourself, why not use it though out the repo. I noticed that std::cout, std::error was used sometimes.
  4. get_log actually means log_init, setlog is actually writing log. Moreover, get_log and setlog have distinct syntax.

NeumoNeumo avatar Apr 22 '23 01:04 NeumoNeumo

1&2&3 are done.

Jayfeather233 avatar Apr 27 '23 08:04 Jayfeather233