Jack

Results 107 comments of Jack

Bit confused with this one, looks like it was designed to be by state date unless you recently changed it @SOF3 ? https://github.com/poggit/poggit/blob/7af4ce0a25a4d5811b2c0904ac6809aa49b1e827/js/release.list.js#L19

tbh I personally think this should be a client sided sort, just send ‘all’ releases to client and leave them to decide how to sort them (based on UI options,...

I have actually looked at this and it's weird githubs done this but essentially they no longer list lgpl-3.0 only lgpl-2.1 so when poggit (successfully) detects slapper using lgpl-3.0 it...

Note the license is still on github but not on the most commonly used list anymore (the list poggit uses) (https://api.github.com/licenses) https://api.github.com/licenses/lgpl-3.0

I’ve just assumed it’s no longer a ‘commonly used’ license can if you want but not sure if they’ll do anything about it. But this means the list is not...

@SOF3 Should we look at changing the license endpoint, github won't list all licenses only commonly used ones which can change depending on usage so never providing a comprehensive list....

Scratch that, could just get the repo’s license as sorted by GitHub as it will have the license key if known, we can use that otherwise it provides us with...

Should be alright, just use the SPDX id from GitHubs response

I'd assume this to be stored in plugin submission as if fetched on review page right now that'd be more than 50 github calls...

Not fixed. Different error has occurred, something to do with the plugin API's array being null when being sorted/listed so search stuff after is never reached due to errors.