JavidPack

Results 170 comments of JavidPack

I don't think I agree that `npcLoot.RemoveWhere(r => r is CommonDrop drop && drop.itemId == item.type);` should remove common drop rules nested within other rules. You have to be exact...

Oh, so just to be clear, in the case you mentioned, you would have to match LeadingConditionRule, then iterate through its ChainedRules to find the matching CommonDrop to remove it...

#2707 will take care of the localization deficiency, but DialogSubstitution will be it's own issue

#2964 will be the DialogSubstitution issue, it'll probably need some thought.

[d20a56a](https://github.com/tModLoader/tModLoader/commit/d20a56a00bb8de7cbaa4a28d81c58e55fcbbc674) implements this.

This has been brought up before, and I personally don't agree. My feeling is that the very nature of tModLoader and ExampleMod is that they have to move in tandem...

In addition to this, I'd like to have a button in the Mod Sources menu that downloads the examplemod that corresponds to the release the user is running. We'll have...

We'll also want to autoregister known keys, such as keybinds and townnpcs