Javacord icon indicating copy to clipboard operation
Javacord copied to clipboard

Replacement/just removal and deprecation of `getDiscriminatedName `

Open TheKodeToad opened this issue 2 years ago • 8 comments
trafficstars

What feature are you proposing?

getDiscriminatedName is no longer desirable as users who've migrated to the new username system will have no discriminator (represented as 0). I personally don't think changing the behaviour of the method is a good idea as the name implies that it will have a discriminator!

The method could have a replacement which drops #0... however at some point both getDiscriminatedName and this method will become useless

Do you have any additional material for your feature proposal?

No response

TheKodeToad avatar May 20 '23 18:05 TheKodeToad

Regarding this, as the user no longer has a discriminator it could be made where getUserName provides you with the @ userName and getGlobalName gets there display Name. getDiscriminatedName should be marked as @deprecated but no removed until bots migrate too

RealYusufIsmail avatar Aug 23 '23 12:08 RealYusufIsmail

There are still regular users with discriminators

TheKodeToad avatar Aug 23 '23 13:08 TheKodeToad

There are still regular users with discriminators

Majority have migrated but I said keep it

RealYusufIsmail avatar Aug 23 '23 14:08 RealYusufIsmail

You should not deprecate something which should be used imo

TheKodeToad avatar Aug 23 '23 14:08 TheKodeToad

You should not deprecate something which should be used imo

but it will be removed in the future.

RealYusufIsmail avatar Aug 23 '23 14:08 RealYusufIsmail

@TheKodeToad if you wish you can have a look at the pr i made a while back and see if you have any suggestions for amendment.

RealYusufIsmail avatar Oct 27 '23 22:10 RealYusufIsmail

but it will be removed in the future.

Well, the PR's merge will need to be delayed.

TheKodeToad avatar Oct 28 '23 09:10 TheKodeToad

but it will be removed in the future.

Well, the PR's merge will need to be delayed.

why. you need make users aware.

RealYusufIsmail avatar Oct 28 '23 12:10 RealYusufIsmail