Java-Discord
Huge amount of scam links going undetected by Automod
Currently, Javabot relies on the file src/main/resources/spamLinks.txt for detecting scam links, but this file was updated 3 years ago, it should be considered to update the file to contain the newest URLs
I am unsure about the extent this file is actually used since the bot seems to load the new version of the spam URLs on startup.
I am unsure about the extent this file is actually used since the bot seems to load the new version of the spam URLs on startup.
it does load it in memory but it should not be tooooo big of a problem unless the bot is hosted on a toaster, and I skimmed through the last few scam URLs sent on the server, the updated file in #482 seems to contain 9/10 of those URLs
After doing a quick calculation, the file loads 195.73 KB of data in memory, which seems pretty reasonable.
it does load it in memory but it should not be tooooo big of a problem unless the bot is hosted on a toaster, and I skimmed through the last few scam URLs sent on the server, the updated file in https://github.com/Java-Discord/JavaBot/pull/482 seems to contain 9/10 of those URLs
This is not about the amount of URLs. I was saying that I think that the bot actually doesn't use the file specified in the resources directory but automatically downloads the newest version and uses that.
it does load it in memory but it should not be tooooo big of a problem unless the bot is hosted on a toaster, and I skimmed through the last few scam URLs sent on the server, the updated file in #482 seems to contain 9/10 of those URLs
This is not about the amount of URLs. I was saying that I think that the bot actually doesn't use the file specified in the resources directory but automatically downloads the newest version and uses that.
I missed that, well in that case the file should be removed from resources directory
If that file is actually unused, it might be good to completely delete it but it would be necessary to verify this.
Originally, it was loaded from resources but this was changed to automatically fetch it and the file might be completely obsolete since then (unless it would be in use somewhere else and I didn't find anything with a full-text search on spamLinks.txt so we can probably delete the file altogether.
As described above, that file wasn't used and has even been removed by now.