marten icon indicating copy to clipboard operation
marten copied to clipboard

Allow to reuse internal Marten infrastructure

Open petriashev opened this issue 2 years ago • 6 comments

Initial point of view.

petriashev avatar Nov 21 '21 20:11 petriashev

CLA assistant check
All CLA requirements met.

dnfadmin avatar Nov 21 '21 20:11 dnfadmin

@petriashev Looks like there is a compile time error hence the CI builds are all failing. Please have a look.

mysticmind avatar Nov 22 '21 05:11 mysticmind

@petriashev Looks like there is a compile time error hence the CI builds are all failing. Please have a look.

Done. That was partial work

petriashev avatar Nov 22 '21 06:11 petriashev

I'm a hard no on this PR. I don't want all these internals exposed. We can talk about a more expansive set of fancier document metadata first before we do any of these structural changes for a one off scenario.

jeremydmiller avatar Nov 22 '21 18:11 jeremydmiller

Hello what should I remove from PR to make it acceptable?

petriashev avatar Dec 21 '21 10:12 petriashev

I have tryed to copy needed classes but It is easier to fork all project. All infrastructure code is not reusable

petriashev avatar Dec 21 '21 18:12 petriashev

@petriashe, I’m really sorry for keeping this PR open for so long. I’m going to close it, as in the meantime a lot of changes happened plus we didn't get any other requests to make them public.

Of course, we understand that you might still want to make Marten more customisable. Let’s tackle those concerns in a dedicated issue first or on Discord to better understand your needs and how we could help.

oskardudycz avatar May 02 '23 18:05 oskardudycz