jqbx-issues icon indicating copy to clipboard operation
jqbx-issues copied to clipboard

Downvoting in large rooms doesn't skip

Open Myztiq opened this issue 7 years ago • 2 comments

If there is a room with 161 people (wow) since it requires >50% to skip we should instead have it have a number threshold too. Something sane, perhaps 20 people lame or >50% and it skips.

Myztiq avatar May 31 '18 22:05 Myztiq

This would be a great feature, although I it might be an idea to make the skip threshold a proportion of active users - for example, if the number of downvotes is greater than 25% of the number of distinct users that have voted in the last half hour, the song gets skipped.

mogranjm avatar Jun 05 '18 01:06 mogranjm

Hey guys, yeah I agree this needs to get fixed. I pushed an update to the server on Sunday so that the track will skip based on a log scale. This correlates directly w/ the meter so if you see the meter is all the way to the left, the track will skip. I think this will resolve the issue in most scenarios but let me know if you think it's too strict or too loose still and I will revisit it.

On Mon, Jun 4, 2018 at 9:46 PM, James Morgan [email protected] wrote:

This would be a great feature, I think it would be interesting to make the skip threshold a proportion of active users - for example, if the number of downvotes is greater than 25% of the number of distinct users that have voted in the last half hour, the song gets skipped.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JasonZigelbaum/jqbx-issues/issues/127#issuecomment-394554152, or mute the thread https://github.com/notifications/unsubscribe-auth/AAyHSSjqg5T7NhrGd5HhoQb4HqVIDzwOks5t5eMKgaJpZM4UV107 .

JasonZigelbaum avatar Jun 05 '18 12:06 JasonZigelbaum