JasonLi
JasonLi
> > > The plan looks like aliasing to the same name after `optimize_projections` > > > ``` > > > Projection: test.a AS test.a > > > TableScan: test...
> Here is an alternate implementation proposed by @jonahgao : #12341 thanks @jonahgao @jayzhan211 @alamb
> Thank you @JasonLi-cn > > I wonder if we have tested the performance of this branch? I worry that the incremental output generation will result in a copying the...
## Benchmark(main VS this branch) ``` cargo bench --bench aggregate_query_sql ``` ```shell Gnuplot not found, using plotters backend aggregate_query_no_group_by 15 12 time: [2.1563 ms 2.1686 ms 2.1824 ms] change: [-0.1065%...
> 405 > 🤔 > > ``` > Query 17 iteration 4 took 6144.7 ms and returned 10 rows > Q18: SELECT "UserID", extract(minute FROM to_timestamp_seconds("EventTime")) AS m, "SearchPhrase", COUNT(*)...
> > > I agree, finally it should be a big change which switches the group values and related states managed by block like duckdb , and I am working...
> @JasonLi-cn As I think, `GroupValues` impls maybe should not care about the `batch size`? And we just do the `split and merge` work in the `GroupedHashAggregateStream::poll` , if unfortunately,...