Petr Portnov | PROgrm_JARvis

As another point for discussion, there are some legacy details which may be also influenced if you support it: - I suggest removing legacy methods with typos which were replaced...

Another big job to be done is Advancements as they seem to be broken as I remember. I will probably do the same job as done with `MovingObjectPosition`: implement wrappers...

I have temporarily configured the branch of my fork to deploy artifacts to GH Package Registry so that it is possible to depend on this patch while it is not...

@dmulloy2 could you please allow me to temporarily deploy current legacy-support builds under my coordinates (i.e. `ru.progrm-jarvis.minecraft:PacketWrapper`) at Sonatype OSSRH so that in can be used as a dependency now...

> @JarvisCraft yeah you're absolutely free to deploy your own version under your own coordinates Thanks! Now it is available via [Sonatype OSSRH](https://oss.sonatype.org/content/repositories/snapshots/ru/progrm-jarvis/minecraft/packet-wrapper/). Once the job on this PR is...

> The other question is, whether the regeneration script should be ran or whether this code change should be done manually? As I am aware, the work on new format...

Also receiving `java.lang.NoClassDefFoundError` when performing ```Java public class AdvancementsPacketListener extends PacketAdapter { public AdvancementsPacketListener(final JavaPlugin plugin) { super(plugin, PacketType.Play.Server.ADVANCEMENTS); } @Override public void onPacketSending(final PacketEvent event) { // Right here:...

After the research I've discovered that the problem is in `com.comphenix.protocol.wrappers.AutoWrapper` class being missing in latest published version of ProtocolLib on spigotmc. Fixed by using latest dev build from http://ci.dmulloy2.net/job/ProtocolLib/...

Yet `packet.getAdvancements()` throws NullPointerException.

`java.lang.StackOverflowError` thrown when calling `packet.getProgress()`,