arduino-music-player icon indicating copy to clipboard operation
arduino-music-player copied to clipboard

Published 20 hours ago • verified publisher icon JarkkoPFC

Fix bug in SXP bit_input_stream leading to incorrect Impulse Tracker conversion

Open Ferdi265 opened this issue 3 years ago • 0 comments

This PR fixes a bug in the bit_input_stream type in the bundled SXP library, which is used by the convert_it() function in the pmf_converter tool.

When refilling the internal cache buffer in bit_input_stream, the m_cache_start_bit_pos variable is always moved forward by a full buffer size, even when fewer bytes than that have been read from the stream. This leads to the bit_input_stream reporting end-of-stream much earlier than intended, which cuts the sample short.

This PR fixes issue #9. After application of this PR, the full voice sample can be heard.

Ferdi265 avatar Jun 01 '22 23:06 Ferdi265