ntscqt icon indicating copy to clipboard operation
ntscqt copied to clipboard

The BIG Pull Request - A lot of things i added

Open rgm89git opened this issue 2 years ago • 3 comments

Those things, includes:

  • Change the extension to MKV for potential enhancements
  • Changes on README
  • Some alterations on the UI (including new checkboxes)
  • New border function
  • New brightness operation (strangely, not working)
  • Somehow, trying at more realistic subcarrier values
  • New lossless exporting option (using the FFV1 codec)
  • And most important: EXPERIMENTAL AUDIO FILTERING

rgm89git avatar May 20 '22 16:05 rgm89git

ntscqt seems to be abandoned ATM

SergeyMC9730 avatar Jun 28 '22 09:06 SergeyMC9730

@JargeZ give me write access so i can merge this big pull request!

SergeyMC9730 avatar Jul 24 '22 08:07 SergeyMC9730

Hi @SergeyMC9730 It is not abandoned, I check how it is used almost every day and have seen all the pull requests and messages.

I'll make a merge and a new version as soon as I can. I have a job and many other projects and problems

I'm sorry that it might seem abandoned, but it's not, everything will be done

JargeZ avatar Jul 24 '22 10:07 JargeZ

@rgm89git Please can you open new pull requests for different features?

Branches involve working in them in the process of change and merging as features are ready.

Each branch should correspond to a separate feature. It is not necessary to mix already completed and working changes in one branch and only testing and WIP changes as a new_ui

I merge this pull request with the main features that I tested

JargeZ avatar Aug 20 '22 18:08 JargeZ

You can open new ones to work on:

  1. Audio refinement (I did not remove the main one from this pull request)
  2. Brightness, I will help you understand what did not work in a separate branch
  3. More realistic subcarrier and sliders

JargeZ avatar Aug 20 '22 18:08 JargeZ

You can open new ones to work on:

1. Audio refinement (I did not remove the main one from this pull request)

2. Brightness, I will help you understand what did not work in a separate branch

3. More realistic subcarrier and sliders

Ok, tell me about how i can do these separate branches, so we can start now.

rgm89git avatar Aug 20 '22 18:08 rgm89git

@rgm89git Create a new branch from master, name it as the feature short name for semantic

Work on this feature in it and create a pull request from this branch to the master

There can be any number of separate branches with features (important, from the master) And if necessary, you can checkout between them to work on different features

JargeZ avatar Aug 20 '22 18:08 JargeZ