responsive-layout icon indicating copy to clipboard operation
responsive-layout copied to clipboard

ResponsiveColumn introduces an unnecessary div

Open chvndb opened this issue 8 years ago • 2 comments

Is there a specific reason why ResponsiveColumn extends StyleableComponent and not CssLayout?

This introduces an unnecessary div, which makes css tweaking more difficult.

chvndb avatar Aug 14 '17 00:08 chvndb

I can't remember the exact reason offhand but I attempted to use CSSLayout initially, However something didn't pan out with it, it may have been a Vaadin Quirk or how the CSS I was using needed to be structured.

JarekToro avatar Aug 15 '17 13:08 JarekToro

I see, in that case it might be better to avoid the extra div and avoid any unexpected quirks.

chvndb avatar Aug 26 '17 09:08 chvndb