Jason Newcomb

Results 26 issues of Jason Newcomb

fixes: #1368 fixes: #2308 Worklist of things still to do: * ~~Finish checking types for constraints. e.g. `dyn Iterator` would require `T` be `Sized`~~ * ~~Actually resolve dependencies. e.g. `T:...

S-waiting-on-review

This will need a new version of `ui_test` to be released before it will work. changelog: None

S-waiting-on-review

fixes #2834 fixes #6816 changelog: `float_cmp_const`: Deprecate in favor of a config option on `float_cmp`. changelog: `float_cmp`: Don't lint self comparisons. changelog: `float_cmp`: Don't lint literal comparisons. changelog: `float_cmp`: Add...

S-waiting-on-review

fixes #11365 This approach has false-negatives, but fixing them will require a significant amount of additional state tracking. The comment in `add_and_pats` has the explanation. changelog: `single_match`: correct checking if...

S-waiting-on-review

Splitting up #177 for easier review. fixes #166 fixes #146 fixes #141

fixes #159 First commit fixes the clipping region to the render region. Second commit keeps the game from stealing the mouse cursor's position until the mouse actually interacts with the...

fixes #140 Both the river of flame and various parts of act 5 need to hash over 1MB per frame. I've measured hashing adding about 20ms-50ms per frame which causes...

Splitting up #177 for easier reviewing. Really this should use multiple staging buffers, but just shrinking it works well enough. hopefully fixes #125

Splitting up #177 to make reviewing easier. First commit removes the renderer's dependence on the widescreen flag. Not strictly needed, but it doesn't hurt anything. fixes #99

Splitting up #177 to make reviewing easier. fixes #172 fixes #167 fixes #165 fixes #155 fixes #95 fixes #38