TF2-Hud-Reference icon indicating copy to clipboard operation
TF2-Hud-Reference copied to clipboard

Remove nonexistant HL2 anims & add some unused anims

Open treacherousfiend opened this issue 3 years ago • 3 comments

Right now this is a draft PR because i'm not sure this is the best way to go about this. I've removed all of the HL2 animations which are not in the game, as well as the ones which are also in hudanimations_tf. I've also added a couple of potentially unused animations which are in the game.

HudReplayReminderIn and HudReplayReminderIn2 might be a remnant from when replays were enabled on valve servers? I'm not entirely sure of that though

I assumed that TimerFlash may have been superseded by TimerIncrement and TimerDecrement, But it actually appears that TimerIncrement and TimerDecrement do not even exist! I haven't changed anything about them being mentioned yet, but i think maybe its a remnant of Pre-matchhud TF2, as I seem to remember the timer flashing when you capture a point, although i haven't been able to find any footage of it

HintMessageLower and HintMessageRaise appear to be remnants of HL2, specifically the part of the hud which shows a history of what items you've picked up. This may not work at all in TF2

eventHudCartAlarmPulseStop (the camelcase is intentional) appears to be a misspelling of HudCartAlarmPulseStop, as the latter doesn't exist! this is never noticeable in game because the same code that calls this animation also sets the visibility of the panel itself to false. seems like someone might've copied the name of the animation from hudanimations_tf and accidentally removed the space between event and HudCartAlarmPulseStop. I've already emailed Valve about this, but i'm not entirely sure they'll ever fix it since its not visible in game and 1 animation always running probably is not super performance intensive.

treacherousfiend avatar Feb 03 '22 09:02 treacherousfiend

I assume "are in the game" means referenced by (potentially unreachable, but potentially reachable) code? So at least a few of them might run ingame, but they just don't show up because they're not defined anywhere (and if they were defined, they would work fine)? I think the easiest approach would be to have the "unused animations" category be "file-less" and point out in their descriptions if they're unused but still appear in code. It's not a major change, but it fits with the format of separating by file.

Might be worth adding a description for the "hudanimations.txt" category about stripping out animations that aren't ever used ingame, just to avoid any confusion if someone looks at the file and notices how there's a ton more than listed here.

JarateKing avatar Feb 04 '22 04:02 JarateKing

Yeah, these are potentially reachable.

I'll add a couple notes and i guess we can figure it out from there!

treacherousfiend avatar Feb 04 '22 04:02 treacherousfiend

👍

Pudding555 avatar Jun 30 '22 12:06 Pudding555