janusgraph icon indicating copy to clipboard operation
janusgraph copied to clipboard
verified publisher icon JanusGraph

4084: adds Couchbase as JanusGraph backend

Open chedim opened this issue 2 years ago • 4 comments

Issue #4084 This PR adds couchbase JanusGraph backend and search. The backend is in alfa stage and is not yet recommended for production use.

All the dependencies for the backend are either already in other poms (logback) or use licenses from category a.

Thank you for your time reviewing the PR. Suggestions on the code are highly welcomed as this was our team's first project with JanusGraph.

Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

For all changes:

  • [x] Is there an issue associated with this PR? Is it referenced in the commit message?
  • [x] Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
  • [x] Is your initial contribution a single, squashed commit?

For code changes:

  • [x] Have you written and/or updated unit tests to verify your changes?
  • [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • [ ] If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • [ ] Have you ensured that format looks appropriate for the output in which it is rendered?

chedim avatar Oct 31 '23 20:10 chedim

CLA Not Signed

  • :x: - login: @chedim / name: Dmitrii Chechetkin . The commit (0123c4c2a75dff893086f428447a22ac96747eff, 9bbed638de5221021100cd47245f824d81fd85ff, bbd8f70b3acb2200375002648f0565635badde6b, 1367f473baef4614a558bd1a2efc399dd91a04b7, 6ec1d8c6f9372383d32c9761678424dae4acfba2, c4e454c2913cddd384ecf99cc47cdec34b824dbf) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

linux-foundation-easycla[bot] avatar Oct 31 '23 20:10 linux-foundation-easycla[bot]

CLA Not Signed

* [❌](https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/1543822/77385607/4086/#/?version=2) - login: @chedim / name: Dmitrii Chechetkin . The commit ([d595025](https://github.com/JanusGraph/janusgraph/commit/d595025b681606d8a903613bb5b7e8b7ecac338d)) is not authorized under a signed CLA. [Please click here to be authorized](https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/1543822/77385607/4086/#/?version=2). For further assistance with EasyCLA, [please submit a support request ticket](https://jira.linuxfoundation.org/servicedesk/customer/portal/4).

Working on this internally with Couchbase, should be signed within the week.

chedim avatar Oct 31 '23 20:10 chedim

The CLA part is taking much longer than I've expected. Escalated it, will post an update when it is signed.

chedim avatar Nov 13 '23 16:11 chedim