janusgraph icon indicating copy to clipboard operation
janusgraph copied to clipboard

Only java 11

Open farodin91 opened this issue 2 years ago • 3 comments


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

For all changes:

  • [ ] Is there an issue associated with this PR? Is it referenced in the commit message?
  • [ ] Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
  • [x] Is your initial contribution a single, squashed commit?

For code changes:

  • [x] Have you written and/or updated unit tests to verify your changes?
  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • [ ] If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • [ ] Have you ensured that format looks appropriate for the output in which it is rendered?

farodin91 avatar Oct 08 '23 19:10 farodin91

@farodin91 Do you think we can do this in the next major release, e.g. 2.0.0? We could send an announcement (that java 8 will no longer be supported) once 1.0.0 is released.

li-boxuan avatar Oct 10 '23 07:10 li-boxuan

@li-boxuan We can move this to 2.0. We have to change the upcoming latest version in the build pipeline.

farodin91 avatar Oct 10 '23 15:10 farodin91

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.