janusgraph icon indicating copy to clipboard operation
janusgraph copied to clipboard

Move Docker image into main repository

Open FlorianHockmann opened this issue 2 years ago • 1 comments

We have decided to move the Docker image from the janusgraph-docker into this repo here to simplify the development workflow and to improve the usability of the security scanning.

This includes the following tasks:

  • [x] Move the image itself in the repository: #3782.
  • [x] Set the required tags: latest / 1.0 / 0.6. #3842
  • [ ] Integrate the documentation more nicely in the docs. The README.md from janusgraph-docker was its own independent documentation.
  • [x] Add ghcr.io registry as alternative https://github.com/JanusGraph/janusgraph/pull/3796
  • [x] Mark janusgraph-docker as archived https://github.com/JanusGraph/janusgraph-docker/pull/135
  • [x] add docker hub logins to secrets
  • [x] https://github.com/JanusGraph/janusgraph/issues/3905

FlorianHockmann avatar Jun 02 '23 13:06 FlorianHockmann

The pushing of the Docker image is currently failing on master and I'm not sure why:

[INFO] --- exec-maven-plugin:3.1.0:exec (docker-deploy) @ janusgraph-dist ---
usage: build-and-push-image.sh version base-image build-path tag-suffix [push]
Error:  Command execution failed.

The login to Docker Hub before that was successful and it should be using our Docker Hub bot now as I've added a token for that to the secretes. The token also should have the necessary permissions.

FlorianHockmann avatar Jun 09 '23 09:06 FlorianHockmann