janusgraph
janusgraph copied to clipboard
Implement mixed index aggregations
Fixes #3202
Thank you for contributing to JanusGraph!
In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:
For all changes:
- [x] Is there an issue associated with this PR? Is it referenced in the commit message?
- [x] Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
- [x] Has your PR been rebased against the latest commit within the target branch (typically
master
)? - [x] Is your initial contribution a single, squashed commit?
For code changes:
- [x] Have you written and/or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
- [ ] If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
- [ ] If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?
For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: To-om / name: toom (8fa21ec51012eec7f844af6ba659256a9b81e973)
@To-om
janusgraph-solr/src/main/java/org/janusgraph/diskstorage/solr/SolrIndex.java#L781 Added line #L781 was not covered by tests
@To-om could you please squash your commits into a single commit?
If it's complicated then you can just hard reset from this branch: https://github.com/porunov/janusgraph/tree/aggregations
Alternatively you can click Allow edits and access to secrets by maintainers
on this PR and I will force push into your branch.