activate cql tests for cassandra 4 [tp-tests]
Fixes #3017
- Upgrade Cassandra testing dist version to 4.0.6
- Enable full dist builds on java 11 tests
- Fix log collection during local testing
Thank you for contributing to JanusGraph!
In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:
For all changes:
- [ ] Is there an issue associated with this PR? Is it referenced in the commit message?
- [ ] Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically
master)? - [ ] Is your initial contribution a single, squashed commit?
For code changes:
- [ ] Have you written and/or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
- [ ] If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
- [ ] If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?
For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
@farodin91 Thank you for the fixes! Do you think it's possible to split Cassandra version update (which I think is related to #2325) and dist tests fix (which is related to #3017) to 2 different PRs? I think we need to fix dist tests bug in v0.6 branch. Otherwise we won't be able to release 0.6.x versions anymore.
@FlorianHockmann Would you like to review?
Would you like to review?
I just tried to review this again, but I'm still a bit confused: Is this now the PR to update Cassandra to version 4? In that case, this also fixes #2325 as @porunov noted, but then it should definitely be clearly documented in the changelog.
I have a dumb question: when we say "java 11 support" do we use it at compile time or runtime or both?
runtime and compile and not source
I just tried to review this again, but I'm still a bit confused: Is this now the PR to update Cassandra to version 4? In that case, this also fixes https://github.com/JanusGraph/janusgraph/issues/2325 as @porunov noted, but then it should definitely be clearly documented in the changelog.
It looks like this PR upgrades only distribution version of Cassandra to Cassandra 4. In pom.xml we still use Cassandra 3.
cql hadoop can't be replaced directly. We have to switch to the spark read by datastax.
@FlorianHockmann Would you like to review it again?
@porunov Would you like to review this PR?
@FlorianHockmann I've fixed both comments.