jans icon indicating copy to clipboard operation
jans copied to clipboard
verified publisher icon JanssenProject

docs: correct typo in security-best-practices.md

Open Rehket opened this issue 1 year ago • 1 comments

Description

  • Documentation: Properties is misspelled in https://github.com/JanssenProject/jans/blob/main/docs/admin/planning/security-best-practices.md

  • Development target issue: NA

  • Implementation Details: NA

Prepare

  • [x] Read contribution guidelines
  • [x] Read license information

Identified code changes

  • [x] Update documentation to fix the typo.

Test cases and code coverage

  • NA

Document the changes

  • NA

Rehket avatar Jun 13 '24 14:06 Rehket

I created a PR for the typo fix, I've not really contributed to open source before, if there is anything I have missed, please let me know!

In this instance, since I created the PR to correct the typo, should I assign the issue to myself?

Thanks for the feedback!

Rehket avatar Jun 13 '24 15:06 Rehket

@Rehket First of all, thank you for coming forward and making this contribution .. :+1:

We are reviewing your PR.

Yes, go ahead and assign it to yourself.

ossdhaval avatar Jul 08 '24 11:07 ossdhaval

It looks like I don't have permission to assign myself.

Regardless, let me know if actions or additional input is needed. Thank you!

Rehket avatar Jul 08 '24 15:07 Rehket