jans icon indicating copy to clipboard operation
jans copied to clipboard

fix(forgot_password): update script according to jans specs

Open christian-hawk opened this issue 2 years ago • 3 comments

Prepare


Description

Target issue

ref issues #1601 #1631

Implementation Details


Test and Document the changes

  • [ ] Static code analysis has been run locally and issues have been fixed
  • [ ] Relevant unit and integration tests have been added/updated
  • [ ] Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

christian-hawk avatar Jun 29 '22 16:06 christian-hawk

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jun 29 '22 16:06 sonarqubecloud[bot]

I haven't signed the commit, if this is a blocker please let me know.

christian-hawk avatar Jun 29 '22 16:06 christian-hawk

I haven't signed the commit, if this is a blocker please let me know.

yes this is a blocker. All commits have to be signed. Your commit though looks signed

moabu avatar Jul 05 '22 10:07 moabu

@moabu @yuriyz @duttarnab @devrimyatar I was requested to make this PR ready for review, just please notice the message I left in our internal communication channel #project_jans :

I created a draft PR that updates the scripts imports but not fix the related GitHub issues thou, as non of them are related to script functionality. They are related to Jans server startup (Initializing scripts) and cli authentication

So, this PR will NOT solve linked issues #1631 #1601 . I suggest UNLINKING the issues to avoid closing them by this merge.

Just making sure everybody is aware, making it ready for review right now.

christian-hawk avatar Sep 24 '22 17:09 christian-hawk