mod-director icon indicating copy to clipboard operation
mod-director copied to clipboard

Option to bypass installation checks after first successful startup

Open DrParadox7 opened this issue 4 years ago • 3 comments

ModDirector provides the perfect solution when needing to download only a handful of mods, however in my case where over 50 entries are necessary, the process of checking the installation can add quite a long time to the game startup every session.

Could there be an option for ModDirector to output a file on the first successful startup (possibly a log indicating the status of all entries) and, if it exists at the next restart, completely forego the checking process for the sake of faster loading times?

Successful startup as in: If all entries have been downloaded successfully then disable installation checks

DrParadox7 avatar Oct 20 '21 00:10 DrParadox7

Benchmark (no downloads, just installation checks): 60 entries currently adds 60 seconds to the startup time at every launch.

DrParadox7 avatar Nov 02 '21 21:11 DrParadox7

The long delays are caused by a thread.sleep in the install controller. Im not sure why it is there. It seems to run fine without it.

https://github.com/Janrupf/mod-director/blob/e482e09191f52057dd5e4a6428695df7202516e0/mod-director-core/src/main/java/net/jan/moddirector/core/manage/InstallController.java#L134

bambam01 avatar Nov 06 '21 17:11 bambam01

And this is why you should check your code after debugging: https://github.com/Janrupf/mod-director/commit/c657ffd55a1c2bcf54a3681c6b99aeaec6d3b1c4

Anyway, leaving this open since the issue is still valid

Janrupf avatar Nov 06 '21 18:11 Janrupf