blockbench icon indicating copy to clipboard operation
blockbench copied to clipboard

add arm64 and armv7l arches to linux CI

Open theofficialgman opened this issue 1 year ago • 4 comments

Known issues: 3rd party library is 4+ years unmaintained and does not have ARM64 or ARMhf scrot native binaries on linux https://www.npmjs.com/package/electron-color-picker

electron-color-picker should be moved away from anyway as it is not wayland compatible which is the current default window system on linux desktops in 2024

you will likely want to move to gcolor3 as it seems to work well for me on wayland and x11 due to using the xdg desktop portals for obtaining color information https://www.hjdskes.nl/projects/gcolor3/

I am not actually sure what this library is being used for in blockbench as the "pick screen color" option in the paint section does work on ARM64 xorg linux in testing but not in wayland on any architecture.

theofficialgman avatar Jan 15 '24 18:01 theofficialgman

@JannisX11 thoughts? I would have expected some response by now.

theofficialgman avatar Feb 20 '24 18:02 theofficialgman

@JannisX11 Getting rid of electron-color-picker is an excellent idea. Please let us know what kind of feedback you need. There are a lot of Linux users here.

txtsd avatar May 10 '24 09:05 txtsd