jQuery-EasyTabs icon indicating copy to clipboard operation
jQuery-EasyTabs copied to clipboard

Tab page scroll bug

Open MrAllaker opened this issue 12 years ago • 9 comments

Hi I have installed your tabbed panels on http://positivereactionpr.co.uk/new-site/index.html to show and hide client info when a logo is clicked, the install seems to be good but I notice that sometimes when the plugin fires the page scrolls randomly down a couple of hundred pixels. I noticed the bug on your demo page also??

MrAllaker avatar Sep 19 '13 21:09 MrAllaker

I have not had this problem, nor could I observe it in your page. What browser are you using?

JangoSteve avatar Sep 19 '13 21:09 JangoSteve

Hi thanks for coming back to me so quicky,

I have noticed the bug in firefox 23.0.1

It's really strange most of the time it works flawlessly but every now and then I get this page jumping. probably one in every ten instances or so.

On Thu, Sep 19, 2013 at 10:15 PM, Steve Schwartz [email protected]:

I have not had this problem, nor could I observe it in your page. What browser are you using?

— Reply to this email directly or view it on GitHubhttps://github.com/JangoSteve/jQuery-EasyTabs/issues/136#issuecomment-24773913 .

MrAllaker avatar Sep 19 '13 21:09 MrAllaker

It seems to be more apparent if you open and then close the same tab before going on to open another one?

On Thu, Sep 19, 2013 at 10:15 PM, Steve Schwartz [email protected]:

I have not had this problem, nor could I observe it in your page. What browser are you using?

— Reply to this email directly or view it on GitHubhttps://github.com/JangoSteve/jQuery-EasyTabs/issues/136#issuecomment-24773913 .

MrAllaker avatar Sep 19 '13 21:09 MrAllaker

Ah yes, I see it now. When you close the active tab and then click another tab, it seems to wait until after the second tab is shown before it updates the hash. That's most likely what's causing it to jump (see explanation here). That's definitely a bug.

JangoSteve avatar Sep 19 '13 21:09 JangoSteve

Thanks for looking into it.

Easy to fix??

On Thu, Sep 19, 2013 at 10:27 PM, Steve Schwartz [email protected]:

Ah yes, I see it now. When you close the active tab and then click another tab, it seems to wait until after the second tab is shown before it updates the hash. That's most likely what's causing it to jump (see explanation herehttps://github.com/JangoSteve/jQuery-EasyTabs/issues/124#issuecomment-23886111). That's definitely a bug.

— Reply to this email directly or view it on GitHubhttps://github.com/JangoSteve/jQuery-EasyTabs/issues/136#issuecomment-24774749 .

MrAllaker avatar Sep 19 '13 21:09 MrAllaker

Not off the top of my head, it'd probably take some looking into.

For a short-term fix though, you could turn off the hash updating.

JangoSteve avatar Sep 19 '13 21:09 JangoSteve

ok cool is that as simple as just not referencing jquery.hashchange.min.js?

On Thu, Sep 19, 2013 at 10:30 PM, Steve Schwartz [email protected]:

Not off the top of my head, it'd probably take some looking into.

For a short-term fix though, you could turn off the hash updating.

— Reply to this email directly or view it on GitHubhttps://github.com/JangoSteve/jQuery-EasyTabs/issues/136#issuecomment-24774993 .

MrAllaker avatar Sep 19 '13 21:09 MrAllaker

That's optional, but the main thing is to set the config option updateHash: false.

JangoSteve avatar Sep 19 '13 21:09 JangoSteve

got it, thanks again for your help.

On Thu, Sep 19, 2013 at 10:49 PM, Steve Schwartz [email protected]:

That's optional, but the main thing is to set the config option updateHash: false.

— Reply to this email directly or view it on GitHubhttps://github.com/JangoSteve/jQuery-EasyTabs/issues/136#issuecomment-24776091 .

MrAllaker avatar Sep 19 '13 21:09 MrAllaker