Jane Jeon comments

Results 152 comments of


                                            Jane Jeon

Add typescript definition file

Ooh, you decided to go with the hard one? @geopic So whereas the ACL is an _instance_ of a class in case of `role-acl`, for `casl`, for `@casl/ability`, it needs...

Add typescript definition file

So the thing about this is that `user` and `resource` are based on whatever model classes you're using. But at a high level, I guess both are _instances_ of a...

Error message as to WHY a particular query failed (i.e. "why did I get 403")

Maybe integrate `debug`?

Refactor the whole context mess as its own managed class/type

Wanna take this one on? @sssss465 You'd need to merge in the changes to the `next` branch: https://github.com/JaneJeon/objection-authorize/tree/next

Check if a property exists in the original object before injecting its hashed field

Mind adding the tests for your usecase here? thanks

Check if a property exists in the original object before injecting its hashed field

Sorry, I don't think I understand the problem, but here's my understanding of it and please let me know if I'm misunderstanding it: > so some cases like algolia, which...

Check if a property exists in the original object before injecting its hashed field

Sorry I haven't been able to reply sooner (I'm at the airport), but I promise to get back to this soon. If I don't, just @ me

Empty id field gets passed when .select() method is used

Makes sense. Should require a simple change in https://github.com/JaneJeon/objection-hashid/blob/master/index.js#L55 to "gate" setting any properties so that it's only run if the property was present in the original object as well....

Empty id field gets passed when .select() method is used

Should work, yeah. Just make sure to test your specific use case as well (the select())

Empty id field gets passed when .select() method is used

Cool, mind publishing the PR?