Jan

README, Complete Example uses `unowned self`

1

The [example](https://github.com/IBM-Swift/BlueSocket#complete-example) uses `unowned self` in an asynchronous queue. This is a bad idea for reasons outlined here: https://stackoverflow.com/a/42543070

Homebrew, M1

3

I ran into a few issues trying to build Xit natively for Apple silicon. Most of these were, because the default homebrew root changed from "/usr/local" to "/opt/homebrew". I also...

Build issue, Build for Profiling or Release produces linker error

11

This happens OOTB after issue #336 was resolved: ``` Undefined symbols for architecture x86_64: "_SSLClose", referenced from: _stransport_close in libgit2.a(stransport_stream.c.o) "_SSLCopyPeerTrust", referenced from: _stransport_connect in libgit2.a(stransport_stream.c.o) _stransport_certificate in libgit2.a(stransport_stream.c.o) "_SSLCreateContext",...

Password issues on High Sierra

1

I built 572a798c64365ecf608ed0d710d2348b461b2fb9 yesterday and it works perfectly as a drop-in replacement for 2.4.3 on Sierra. The same build fails on High Sierra (10.13.4) when trying to log into an...

This is described in detail in the file "Shared.xcconfig".

Modernization and Permission Handling

7

Please have a look. I hope I haven’t missed anything. :) As a sidenote: the graphics need updating. High-res icon (1024x1024) and retina support…

Requires Screen Recording Permission for macOS Catalina (10.15) and later

4

If you want to apply the color filtering to more than just the desktop background in macOS Catalina (10.15) or later, you need to enable the “Screen Recording Permission”. This...

Modernization

1

Modernized the project and fixed deprecations. BTW: What about the better_undo branch?

As of iOS 13.

Switching to full screen forces my iPad into portrait mode

1

In build 93 whatever the settings are switching to full screen forces my iPad, iOS 15 into portrait mode. 59 was fine. Can you reproduce?