Jan Tvrdík
Jan Tvrdík
Are there some problem with using the second solution, i.e. having custom connection factory?
`--depth` implies `--single-branch` according to [documentation](https://git-scm.com/docs/git-clone#Documentation/git-clone.txt---depthltdepthgt)
Yes. This is the ouput I get today: ``` OK OK OK OK OK OK OK OK OK OK OK OK OK OK OK OK OK OK OK Segmentation fault...
I also tried GitHub Codespaces, and it took a lot longer to fail, but eventually it did https://codespaces.new/JanTvrdik/php-ext-parallel-segfault ``` Segmentation fault (core dumped) Command failed on iteration 862 ```
That would also be an option, but there are some usecase for keeping it generic, i.e. you could do sth like ```php /** * @param DirectoryListing $listing * @return DirectoryListing...
Maybe we can just put sth like this to `Validator::validate` ``` php if ($schemaUri === '') { $schemaUri = '/schema/' . md5(spl_object_hash($schema)); } ```
I guess you're right. The `registerSchema` behavior is wrong (relying on uniqueness of primary resource identifier even when it's empty string), but `resolve` does never actually read those schemas with...
The collision with #6 is a good observation. > It's unique and will always denote the document from which we started When you call validate with schema A without URL...
What about implementing check in `registerSchema` to prevent accidental overrides ``` php public function registerSchema(stdClass $schema, Uri $uri) { $identifier = $uri->getPrimaryResourceIdentifier(); if ($identifier === '') { // ignore }...
This should now hopefully solve #6 and #11. #15 is out of scope of this already large PR.