openxlsx2 icon indicating copy to clipboard operation
openxlsx2 copied to clipboard

missing tests for xlsb

Open JanMarvin opened this issue 1 year ago • 1 comments

Total coverage is severely impacted by missing xlsb tests. Improving coverage can be tricky, because some tests will fail on big endian systems, maybe we need some way to skip these on big endian systems.

Create a more complex test file with everything possible and unsupported features as well

  • Working features
  • Not working features
  • more complex formulas
  • external references
  • data validation
  • dxfs styles

JanMarvin avatar Jan 20 '24 13:01 JanMarvin

Accidentally closed.

Apparently we do not handle future functions yet. Below a zip file containing an xlsx and an xlsb file using SEQUENCE(5). In the xlsb file we read:

wb$workbook$definedNames
#> [1] "<definedName name=\"_xlfn.SEQUENCE\" hidden=\"1\">#NAME?</definedName>"
wb$worksheets[[1]]$sheet_data$cc$f[1]
#> [1] "User_Defined_Function(1,5)"

This should be converted to:

wb$worksheets[[1]]$sheet_data$cc$f[1]
#> [1] "_xlfn.SEQUENCE(5)"

Archive.zip

JanMarvin avatar Apr 25 '24 12:04 JanMarvin

xlsb file support has been improved, we handle and test more cases, but it will probably remain in this state until somebody steps up to further improve it.

JanMarvin avatar Jun 29 '24 14:06 JanMarvin