ThinkSharp.Licensing
ThinkSharp.Licensing copied to clipboard
Frameworks / packages / cryptography calls updates; minor fix in SignedLicense constructor
This PR includes:
- NuGet packages update (testing project);
- Replaced obsolete constructors 'new MD5CryptoServiceProvider()' and 'new SHA512CryptoServiceProvider()' with 'MD5.Create()' and 'SHA512.Create()' as per Microsoft documentation;
- Frameworks update (.net5 and net framework 4.6.1 are no longer supported);
- Updated SignedLicense construtor to properly pass parameter 'issueDate' instead of DateTime.Now;
- Removed unnecessary using statements.
Note - I didn't update package release notes / version as I don't know how to properly handle this, let me know if I have to make this change before merging.
Closed as I found an issue in tests - reopening when issue is solved.
Reopened PR, tests updated and OK on net core and net framework. At the moment my development environment settings does not allow me to test on netstandard 2.0.
@JanDotNet sorry for this question... is anyone still maintaining this wonderful project?
@JanDotNet sorry for this question... is anyone still maintaining this wonderful project?
Hey fraluderin,
thank you for your contribution, for updating the code / framework dependencies and for the cleanup! This project is still maintained. I have few small comments to your PR. If that is fixed, I'll do some additional tests (there a other improvements that has not been published yet) and publish a new nuget version.
Hi @JanDotNet, thank you. Yes, I fixed that. What can I do to improve my contribution?