Jan De Dobbeleer

Results 119 comments of Jan De Dobbeleer

@justjanne this is a Windows Terminal bug -> https://github.com/microsoft/terminal/issues/8341

@kyoh86 same for me. Falls back to [this check](https://github.com/go-git/go-git/blob/720c192831a890d0a36b4c6720b60411fa4a0159/plumbing/format/index/decoder.go#L302), which, if I remove it, resolves the issue and things actually work. So I have no idea why this check is...

@LNKLEO unfortunately this isn't available from golang without a full custom implementation which goes beyond the scope of oh-my-posh. Pretty sure there's no language out there that supports this though...

@LNKLEO did you look at win32 calls for this?

@LNKLEO what's the benefit of this one over the wifi segment?

@LNKLEO exactly, so the wifi segment is redundant in that case. I would remove the wifi segment in favor of a network segment.

@LNKLEO the review is on my list when I get the time (as it larger, I will probably rework myself, so no need to keep rebasing).

@LNKLEO I was trying to look at the actual code here to see how we could improve it as it's very inflexible (and complicated). I'm going to solve that challenge...

@ehawman shouldn't a shell at least try to cover some backwards compatibility? I don't see why they would fundamentally break this, although granted they're on 0.X.