lomiri-notch-hax icon indicating copy to clipboard operation
lomiri-notch-hax copied to clipboard

Add beyond1 (Samsung Galaxy S10) and k63v2_64_bsp (Volla X) support

Open SchmueI opened this issue 3 years ago • 3 comments

This Update includes the following devices:

  • Samsung Galaxy S10
  • Volla X Also it fixes a bug that the packages need to be updated via sudo apt update -y (See PR6)

SchmueI avatar Dec 08 '21 17:12 SchmueI

Hello. I struggled today to make this work on gx290 plus by creating a local diff with yggdrasilx.diff as name instead of your volla x code name and with the same content. I had to change from 3.9 to 6 the not expanded height of the top bar to see half of the icons from network and wifi. Maybe an align to bottom will solve that. Then I put instead of 64, 30 for top margin when expanded and for expanded top bar height I replaced the 3.9 with 2 that was added to 7. Thanks for this.

ps. if something goes wrong, the .cache/unity8-notch-hax folder must be deleted and only after that retried. I put the new diff in that folder by the way and that is how I made it work.

ghost avatar Mar 23 '22 21:03 ghost

@SchmueI So is it beyond1 or bayond1 (current diff filename)? I have a hard time believing this was tested properly. what does getprop ro.product.device and getprop ro.product.vendor.device say?

Also, if you can please:

  • Drop the commits not relevant to S10
  • Amend/fixup the remaining commits so that there's a single Add Samsung Galaxy S10 support or whatever commit in your branch

JamiKettunen avatar Jun 30 '22 22:06 JamiKettunen

Marking as a draft due to my previous comment still not being acknowledged half a year later.

JamiKettunen avatar Jan 01 '23 23:01 JamiKettunen