James Brown

Results 242 comments of James Brown

@asif-finimble I refactored the code to make this slightly simpler - although you will now have to accomodate EIP1559 and Legacy transactions. Ping me for more info if required, but...

@seabornlee "It's not a bug, it's a feature" This stems from when we decided to display all known contracts, so if you open up a new wallet it will show...

As an aside, are we being etherscan rate limited now? It makes sense. They will want to monetise their API. We do have an Etherscan API key but it's free...

It should do a balance update before it even displays in the wallet view. I've spent a lot of time in that area, it should be perfect (almost) - we...

Hi @Satoshiisgod I can't merge this - can you resolve the merge conflict from your end?

Yes. In theory importing TokenScript files via clicking on them is only done during development of the scripts, But yes we should restrict that, maybe in the TokenScript Management page...

Hi @Satoshiisgod I can't merge this - can you resolve the merge conflict from your end?

> Thanks @JamesSmartCell. I will check this out and play with it. > > Do you have examples or docs of the transaction format for EIP1559? > Yes sorry I'll...

Update: I did the abstraction so user can switch 1559 transactions on/off without affecting anything. Here's how I modified the Gas selection screen: ![Screenshot_20220330-164818_AlphaWallet](https://user-images.githubusercontent.com/12689544/160760227-3220c593-9062-4891-a2cb-33b56c07a633.jpg) Not exactly a full implementation! I...