midi_degradation_toolkit icon indicating copy to clipboard operation
midi_degradation_toolkit copied to clipboard

Published 20 hours ago • verified publisher icon JamesOwers

downloads.extract_zip contains assumptions specific to PPD data

Open apmcleod opened this issue 6 years ago • 3 comments

The overwrite check only works if the zipfile contains a top-level directory named the same as the zip file, and the returned path is potentially useless if this isn't the case.

apmcleod avatar Oct 01 '19 05:10 apmcleod

I've done a codebase search for extract_midi to no avail - I don't find it. Can you clarify this issue?

JamesOwers avatar Nov 13 '19 16:11 JamesOwers

Typo... :P I meant here: https://github.com/JamesOwers/midi_degradation_toolkit/blob/f2a2712bad693062f47594b706f5b6742966873f/mdtk/filesystem_utils.py#L69

apmcleod avatar Nov 13 '19 17:11 apmcleod

Gonna kick till later, it's a low priority 'would be nice' kind of issue.

JamesOwers avatar Nov 15 '19 10:11 JamesOwers