midi_degradation_toolkit icon indicating copy to clipboard operation
midi_degradation_toolkit copied to clipboard

Degradation input validation is not explicitly performed.

Open apmcleod opened this issue 6 years ago • 3 comments

For example, min_duration > max_duration.

Currently, examples like the above will warn with "No valid notes found." (or similar), and return None. Because it can't find a note to shift which will result in a duration in that given range. That's probably fine, but we could also explicitly check parameter settings to give a more explicit warning as to what is happening.

apmcleod avatar Aug 30 '19 02:08 apmcleod

IMO, this is probably not necessary. If people provide invalid args then undefined things will happen. That seems reasonable enough really...

apmcleod avatar Oct 31 '19 03:10 apmcleod

agreed, let's push this on for a later release

JamesOwers avatar Nov 12 '19 15:11 JamesOwers

Removing the milestone.

apmcleod avatar Nov 12 '19 18:11 apmcleod