midi_degradation_toolkit
midi_degradation_toolkit copied to clipboard
Degradation input validation is not explicitly performed.
For example, min_duration > max_duration.
Currently, examples like the above will warn with "No valid notes found." (or similar), and return None. Because it can't find a note to shift which will result in a duration in that given range. That's probably fine, but we could also explicitly check parameter settings to give a more explicit warning as to what is happening.
IMO, this is probably not necessary. If people provide invalid args then undefined things will happen. That seems reasonable enough really...
agreed, let's push this on for a later release
Removing the milestone.