midi_degradation_toolkit icon indicating copy to clipboard operation
midi_degradation_toolkit copied to clipboard

Handle case of zero length notes created in formatters

Open JamesOwers opened this issue 6 years ago • 2 comments

TODO: This rounding may result in notes of length 0.

https://github.com/JamesOwers/midi_degradation_toolkit/blob/703885761088d315bec29718dcd8ba46a6834b69/mdtk/formatters.py#L355

JamesOwers avatar Nov 26 '19 18:11 JamesOwers

We had mentioned that this might be fine (even though the note_off precedes the note_on--which is somewhat important). Any model should just learn that such a case corresponds to a very short note.

Otherwise, we can just not include such notes.

apmcleod avatar Nov 27 '19 01:11 apmcleod

We decided to force all notes to be at minimum length 1. This is because the command format is complicated by length zero notes i.e. note off followed by note on in the same time instance.

JamesOwers avatar Aug 12 '20 13:08 JamesOwers