James Owers comments

Results 43 comments of


                                            James Owers

downloads.extract_zip contains assumptions specific to PPD data

I've done a codebase search for `extract_midi` to no avail - I don't find it. Can you clarify this issue?

downloads.extract_zip contains assumptions specific to PPD data

Gonna kick till later, it's a low priority 'would be nice' kind of issue.

Baseline model improvements and comparisons from literature

I'm going to kick this to the future - we will need this if we write a paper focussing on the models.

double_pianoroll_to_df is very slow.

This isn't priority for ACME v1.0, kicking to Next milestone (but may want to kick even further if it's a bit tricky).

Ensure Randomness and reproducibility

It's a shame not to be able to ensure full reproducibility given some set of parameters for the make_dataset.py script...but I don't think it's priority for the reason you give....

Degradation input validation is not explicitly performed.

agreed, let's push this on for a later release

Liveness of this project

Hi all. Whilst I will not have time to maintain the package by myself, I'm very keen to help with active development - jupyter notebooks do not fill the hole...

Liveness of this project

Thank you very much for that link - you may have just saved a lot of duplicate coding work! I will try it out.

Doc page is broken, seems like a file is missing

Affects 3 doc pages: https://github.com/mpastell/Pweave/search?q=ma.mdw&unscoped_q=ma.mdw

Doc page is broken, seems like a file is missing

@mpastell I think this one is a quick fix - please may you make ma.mdw available again on your website? It's expected at http://mpastell.com/pweave/_static/ma.mdw.